Site Comments & Suggestions

Notification link redirect is incorrect!

  • Last Updated:
  • Jul 4th, 2017 11:54 pm
[OP]
Deal Fanatic
User avatar
Aug 20, 2012
9883 posts
877 upvotes
Pacific Ocean

Notification link redirect is incorrect!

When viewing notifications, clicking the link does not bring you to said post but to first post in the thread. This is annoying when you have a 100 page thread and the notification is referring to a post on page 97 or something but the link redirects you to first post. It used to work when forum was first updated. Now it doesnt. Please correct that.
If the glove don't fit you must acquit! #WINNING
12 replies
[OP]
Deal Fanatic
User avatar
Aug 20, 2012
9883 posts
877 upvotes
Pacific Ocean
Update: Clicking notification quotes/responses works fine now. It brings you to direct response. The upvote/downvote links do not. Still brings you to first post of entire thread rather then the post you received the upvote/downvote.
If the glove don't fit you must acquit! #WINNING
Deal Guru
User avatar
Aug 8, 2012
10198 posts
3803 upvotes
BC
TomRFD wrote:
Dec 15th, 2016 11:24 am
We're aware of this and it's currently being looked into. I have no ETA on a fix right now.
This was reported by me LONG ago on the welcome to the new RFD post. The fix should take a junior programmer 2 minutes to fix.

The notifications for quotes are of this format (and they work):
http: // forums . redflagdeals . com / viewtopic.php ? p=1245678#p1234568

The notifications for up/down votes are of this format (and they DO NOT work):
http: // forums . redflagdeals . com / thread-name-<thread number>/#p12345678

(for a theoretical post numer 12345678)

To get the link to work you can insert a /<page #>/ before the #p12345678 if you know the page number, but for 100+ page threads this can be hopeless.

Meanwhile the viewtopic.php script handles it already ... you can reformat the URL, plunk in the post ID from the broken link and get directly to the up/downvoted post.

This should be a SUPER EASY FIX.
POLL: How frequent is your RRSP-matching?
Plastiq: Pay any bill with credit card for 0-2.5% fee (help meet min spending and keep old cards active!)
Rewards program transfer times (e.g. SPG->Aeroplan, Marriott->SPG, Amex MR->SPG...)
Sr. Member
User avatar
Sep 2, 2010
509 posts
174 upvotes
montreal
ace604 wrote:
Jan 3rd, 2017 4:39 am
This was reported by me LONG ago on the welcome to the new RFD post. The fix should take a junior programmer 2 minutes to fix.

The notifications for quotes are of this format (and they work):
http: // forums . redflagdeals . com / viewtopic.php ? p=1245678#p1234568

The notifications for up/down votes are of this format (and they DO NOT work):
http: // forums . redflagdeals . com / thread-name-<thread number>/#p12345678

(for a theoretical post numer 12345678)

To get the link to work you can insert a /<page #>/ before the #p12345678 if you know the page number, but for 100+ page threads this can be hopeless.

Meanwhile the viewtopic.php script handles it already ... you can reformat the URL, plunk in the post ID from the broken link and get directly to the up/downvoted post.

This should be a SUPER EASY FIX.
More info:

When you go to your user page so see the last posts upvoted, the link works and is in this format:
[THREAD_NAME]/[PAGE_NUMBER]/#p[POST_NUMBER]

But when you go in you notifications, the format doesn't include the PAGE_NUMBER and it doesn't work:
[THREAD_NAME]/#p[POST_NUMBER]

So I agree that it is probably simply a typo and could be easily fixed.
Deal Guru
User avatar
Aug 8, 2012
10198 posts
3803 upvotes
BC
TomRFD wrote:
Dec 15th, 2016 11:24 am
We're aware of this and it's currently being looked into. I have no ETA on a fix right now.
This has been "being looked into" for MONTHS. It's a one-line fix. AND it's SUPER-ANNOYING to not be able to see what post someone up/downvoted in your notifications.

Let me have access to your source code and I will fix this bug in 5 minutes.
POLL: How frequent is your RRSP-matching?
Plastiq: Pay any bill with credit card for 0-2.5% fee (help meet min spending and keep old cards active!)
Rewards program transfer times (e.g. SPG->Aeroplan, Marriott->SPG, Amex MR->SPG...)
Administrator
User avatar
Jun 17, 2013
8366 posts
12708 upvotes
Scarborough
ace604 wrote:
Jun 15th, 2017 10:55 pm
This has been "being looked into" for MONTHS. It's a one-line fix. AND it's SUPER-ANNOYING to not be able to see what post someone up/downvoted in your notifications.

Let me have access to your source code and I will fix this bug in 5 minutes.
It's not quite as easy of a fix as you described but I was able to get the bug ticket moved up. I'll keep this thread updated as I receive more information.
RFD Staff [Forum Rules] [Facebook] [Twitter].
Deal Expert
User avatar
May 10, 2005
27944 posts
3961 upvotes
Ottawa
aznnorth wrote:
Dec 15th, 2016 11:22 am
Update: Clicking notification quotes/responses works fine now. It brings you to direct response. The upvote/downvote links do not. Still brings you to first post of entire thread rather then the post you received the upvote/downvote.
Does not work for me. Clicking on an email notification takes me to the first post in the thread. Neither does the Upvote/Downvote link in notifications.
'Political Correctness is a doctrine, fostered by a delusional minority, and rabidly promoted by unscrupulous mainstream media, which holds the proposition that it is possible to pick up a turd by the clean end.' Anonymous
Administrator
User avatar
Jun 17, 2013
8366 posts
12708 upvotes
Scarborough
Pete_Coach wrote:
Jul 2nd, 2017 8:22 am
Does not work for me. Clicking on an email notification takes me to the first post in the thread. Neither does the Upvote/Downvote link in notifications.
Send me a quote notification link that you received in an email. I'll take a look into it.
RFD Staff [Forum Rules] [Facebook] [Twitter].
Deal Expert
User avatar
May 10, 2005
27944 posts
3961 upvotes
Ottawa
TomRFD wrote:
Jul 2nd, 2017 10:01 am
Send me a quote notification link that you received in an email. I'll take a look into it.
It is all the notifications I get by email Tom. When I click the you can view link, it just takes me to the first page of the thread. It is exactly the same as in the notifications bell on the page.
I deleted the email notifications so I cannot send them to you sorry.
'Political Correctness is a doctrine, fostered by a delusional minority, and rabidly promoted by unscrupulous mainstream media, which holds the proposition that it is possible to pick up a turd by the clean end.' Anonymous
Administrator
User avatar
Jun 17, 2013
8366 posts
12708 upvotes
Scarborough
Pete_Coach wrote:
Jul 2nd, 2017 10:30 am
It is all the notifications I get by email Tom. When I click the you can view link, it just takes me to the first page of the thread. It is exactly the same as in the notifications bell on the page.
I deleted the email notifications so I cannot send them to you sorry.
This should be resolved by the same fix which addresses the voting notification link not directing you to the right post.
RFD Staff [Forum Rules] [Facebook] [Twitter].
Deal Guru
User avatar
Aug 8, 2012
10198 posts
3803 upvotes
BC
TomRFD wrote:
Jul 4th, 2017 1:14 pm
This should be resolved by the same fix which addresses the voting notification link not directing you to the right post.
And anyone too impatient to wait another 6 months for a fix, just type the URL manually into the browser and it will take you to the right post:

viewtopic.php?p=27963372
That's http: // forums . redflagdeals . com / viewtopic.php ? p=27963372 <-- with that p=<post number> being the important bit you get from the broken links that end in #p<postnumber>

That link above will take you to TomRFD's post no matter how many pages per post you have configured.
POLL: How frequent is your RRSP-matching?
Plastiq: Pay any bill with credit card for 0-2.5% fee (help meet min spending and keep old cards active!)
Rewards program transfer times (e.g. SPG->Aeroplan, Marriott->SPG, Amex MR->SPG...)
Deal Guru
User avatar
Aug 8, 2012
10198 posts
3803 upvotes
BC
TomRFD wrote:
Jul 4th, 2017 1:14 pm
This should be resolved by the same fix which addresses the voting notification link not directing you to the right post.
ace604 wrote:
Jul 4th, 2017 11:44 pm
And anyone too impatient to wait another 6 months for a fix, just type the URL manually into the browser and it will take you to the right post:

viewtopic.php?p=27963372
That's http: // forums . redflagdeals . com / viewtopic.php ? p=27963372 <-- with that p=<post number> being the important bit you get from the broken links that end in #p<postnumber>

That link above will take you to TomRFD's post no matter how many pages per post you have configured.
And once the page loads, it still shows as "normal":
http: // forums . redflagdeals . com / notification-link-redirect-incorrect-2065411 / #p27963372

I'm not sure why a co-op junior programmer in first year university didn't fix this already in less than 10 minutes.

When you go to your notifications list here:
https://forums.redflagdeals.com/ucp.php ... ation_list

The upvote notifications are in the format:
https: // forums . redflagdeals . com / thread-title / #p<postid>

The 'reply from' and 'quoted by' notification links are in the format:
https: // forums . redflagdeals . com / viewtopic.php ? p=<postid>#p<postid>

The upvote links don't work. The "reply from" links do.

Copy and paste the code to format the link in the right format, someone's already done it right for those 2 latter cases.

This isn't rocket science.
POLL: How frequent is your RRSP-matching?
Plastiq: Pay any bill with credit card for 0-2.5% fee (help meet min spending and keep old cards active!)
Rewards program transfer times (e.g. SPG->Aeroplan, Marriott->SPG, Amex MR->SPG...)

Top