No, it doesn't.
I don't think you understand what 'double NAT' is.
By putting the PPPoE credentials into your router in PPPoE mode it effectively is connected directly to the internet (the modem is just creating Ethernet packets that it's forwarding to your router). No double NAT involved.
If OTOH you set your router to connect by DHCP, then yes, you have a double NAT situation.